Uploaded image for project: 'Module Tools'
  1. Module Tools
  2. MODTOOLS-66

usfm2osis.py does not create proper OSIS references

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Upstream Problem
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: usfm2osis.py
    • Labels:
      None

      Description

      I have a problem in osis2mod. The version I'm using says: "You are running osis2mod: $Rev: 3016 $"

      The Sword installation was built three or four weeks ago from trunk. The problem occurs only when a footnote occurs after a cross reference which is in the same verse. It is very repeatable. When this combination is made into a module, the cross-reference is correctly formed in the module, but the footnote shows the content of the cross-reference instead of the footnote content. If I remove the cross-reference in its entirety, the footnote is correctly formed. The following OSIS fragment illustrates the input that results in the above. I'll be happy to supply the complete OSIS file if required.

      This is the OSIS fragment.

      <verse sID="Isa.49.6" osisID="Isa.49.6"/>
      And he said to me, <transChange type="added">It is</transChange> a great thing for thee to be called my servant, to establish the tribes of Jacob, and to recover the dispersion of Israel: behold, <note type="crossReference" n="23">15.6: <reference>Acts 13. 47. </reference></note> I have given thee for the <note n="126">49.6: <hi type="italic">Gr. </hi> a perpetual covenant.</note> covenant of a race, for a light of the Gentiles, that thou shouldest be for salvation to the end of the earth.
      <verse eID="Isa.49.6"/>

      When I use osis2mod on it, I end up with the footnote showing "15.6: Acts 13. 47." instead of "Gr. a perpetual covenant."

      This problem is seen whenever a cross-reference is followed by a footnote in the same verse.

      If you require further tests etc. please ask.

        Attachments

          Activity

          Hide
          dmsmith DM Smith added a comment -

          You are correct that this is not a problem with osis2mod. But it may be a valid problem report. I'm thinking that this is either a problem with the USFM or with usfm2osis.py.

          If it is the latter, this report should be adjusted to be a problem of usfm2osis.py and be re-opened.

          I'll be attaching the raw output of osis2mod, momentarily.

          Show
          dmsmith DM Smith added a comment - You are correct that this is not a problem with osis2mod. But it may be a valid problem report. I'm thinking that this is either a problem with the USFM or with usfm2osis.py. If it is the latter, this report should be adjusted to be a problem of usfm2osis.py and be re-opened. I'll be attaching the raw output of osis2mod, momentarily.
          Hide
          dmsmith DM Smith added a comment -

          Reopening to attach the osis2mod output, showing that osis2mod is not the problem.

          I think this should be re-filed against usfm2osis.py until it can be shown that the USFM is bad.

          Show
          dmsmith DM Smith added a comment - Reopening to attach the osis2mod output, showing that osis2mod is not the problem. I think this should be re-filed against usfm2osis.py until it can be shown that the USFM is bad.
          Hide
          dmsmith DM Smith added a comment -

          Test.osis.module is the output of osis2mod on Test.osis.xml using the -d 2 flag to add <milestone resp="v" /> markers showing the locations of verse start and ends.

          You'll note that Jonah 2:10 is present in the file twice. The second time Jonah 2:11 is appended to it. This is to what the index points. This is normal for reversification.

          The point is that it can be easily seen that osis2mod has not molested the input.

          The problem that is at issue here is that the <reference> elements do not have a reference. I think it is a bug in the OSIS schema to not require the reference.

          The SWORD engine will try to guess at what the reference should be by parsing the content of the reference. And it is guessing wrong.

          Show
          dmsmith DM Smith added a comment - Test.osis.module is the output of osis2mod on Test.osis.xml using the -d 2 flag to add <milestone resp="v" /> markers showing the locations of verse start and ends. You'll note that Jonah 2:10 is present in the file twice. The second time Jonah 2:11 is appended to it. This is to what the index points. This is normal for reversification. The point is that it can be easily seen that osis2mod has not molested the input. The problem that is at issue here is that the <reference> elements do not have a reference. I think it is a bug in the OSIS schema to not require the reference. The SWORD engine will try to guess at what the reference should be by parsing the content of the reference. And it is guessing wrong.
          Hide
          dfh David Haslam added a comment - - edited

          My osis2mod log output was FIO, as an aside. It has no significant bearing on the real reported issue.

          The two notes in Jon 2:9 were processed correctly by usfm2osis.py and by osis2mod.

          The cross-reference note was simply not a usable reference - ie - it could never work as a link.
          Xiphos generated the usual popup notification when one hovers the mouse over the x1 marker.

          Perhaps this issue should still be closed on the ground that Chris already knew it needed doing?

          The need for creating proper OSIS references is already listed as a "to do" item in the roadmap remarks lines.
          line 48 : # 1.x xreffix.pl-functionality (osisParse(ref)), requiring SWORD bindings; use toc3 for localization

          In effect, this is an indirect allusion to here:

          http://crosswire.org/wiki/Converting_SFM_Bibles_to_OSIS#Cross-references

          Show
          dfh David Haslam added a comment - - edited My osis2mod log output was FIO, as an aside. It has no significant bearing on the real reported issue. The two notes in Jon 2:9 were processed correctly by usfm2osis.py and by osis2mod. The cross-reference note was simply not a usable reference - ie - it could never work as a link. Xiphos generated the usual popup notification when one hovers the mouse over the x1 marker. Perhaps this issue should still be closed on the ground that Chris already knew it needed doing? The need for creating proper OSIS references is already listed as a "to do" item in the roadmap remarks lines. line 48 : # 1.x xreffix.pl-functionality (osisParse(ref)), requiring SWORD bindings; use toc3 for localization In effect, this is an indirect allusion to here: http://crosswire.org/wiki/Converting_SFM_Bibles_to_OSIS#Cross-references
          Hide
          dmsmith DM Smith added a comment -

          I'd suggest leaving it open until done, serving as a formal report.

          Show
          dmsmith DM Smith added a comment - I'd suggest leaving it open until done, serving as a formal report.

            People

            • Assignee:
              chrislit Chris Little
              Reporter:
              bdrake Barry Drake
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: