Uploaded image for project: 'JSword'
  1. JSword
  2. JS-268

Cannot install both KJVA and KJV

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: o.c.jsword.book.sword
    • Labels:
      None

      Description

      When both KJV and KJVA are installed only the KJV is available in Books.installed().

      This is because each book is checked to see it is not already in the list in SwordBookDriver:
      // Only take the first "installation" of the Book
      Book book = createBook(sbmd);
      if (!valid.contains(book)) {
      valid.add(book);

      but contains(book) eventually compares AbstractBookMetaData for the books where the descriptions are compared, but are the same:
      return getBookCategory().equals(that.getBookCategory()) && getName().equals(that.getName());

      Should we be comparing module name instead of module description? But I would have also thought the KJVA would have a different description to KJV.

        Attachments

          Activity

            People

            • Assignee:
              dmsmith DM Smith
              Reporter:
              mjdenham Martin Denham
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: