JSwordIcon indicating the project type

JSword

Uploaded image for project: 'JSword'
  1. JSword
  2. JS-207

Cannot delete BulCarigradNT

          Details

            Description

            I raised MOD-190 because I couldn't delete BulCarigradNT. There are several comments in MOD-190 that are worth reading but it has been suggested that the logic in JSword's isDeletable method is incorrect although initially I believed the module to be incorrectly named:

            BulCarigradNT is not deletable due to the following code:
            public boolean isDeletable(Book dead)

            { SwordBookMetaData sbmd = (SwordBookMetaData) dead.getBookMetaData(); File dlDir = SwordBookPath.getSwordDownloadDir(); File confFile = new File(dlDir, sbmd.getConfPath()); // We can only uninstall what we download into our download dir. return confFile.exists(); }

            So JSword looks for mods.d/bulcarigradnt.conf but the conf file is called bulcarigrad.conf.

              Attachments

                Activity

                Hide
                Permalink
                dmsmith DM Smith added a comment -

                JSword should as it reads a conf, store the name of the conf so that it is authoritative. Right now, it assumes that the name of the conf matches the "initials", that is the name in the [] at the top of the file. Such as KJV.

                This has been true in the past for modules hosted at CrossWire, but it is not true for xiphos and ibt.

                Thanks for figuring this out.

                Show
                dmsmith DM Smith added a comment - JSword should as it reads a conf, store the name of the conf so that it is authoritative. Right now, it assumes that the name of the conf matches the "initials", that is the name in the [] at the top of the file. Such as KJV. This has been true in the past for modules hosted at CrossWire, but it is not true for xiphos and ibt. Thanks for figuring this out.

                  People

                  • Assignee:
                    dmsmith DM Smith
                    Reporter:
                    mjdenham Martin Denham
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: