Uploaded image for project: 'JSword'
  1. JSword
  2. JS-126

Can we consider increasing the timeout value in WebResource

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.6.1
    • Component/s: o.c.common.util
    • Labels:
      None
    • Environment:

      Android mobile

      Description

      Can we consider increasing the timeout value at the bottom of o.c.common.util.WebResource.java? I am using a timeout of 3 seconds in And Bible and it seems to have helped connection reliability.

      I suspect the timeout was originally 2 seconds because there is a comment half way down the file (which probably needs correcting) that says:
      // Set a 2 second timeout on getting a connection.
      and then the code sets the timeout to 0.75 sec.

      Mobile phones have very variable connections and some informal tests seemed to show that increasing the timeout to 3 seconds had a beneficial affect.

      Alternatively, another possibility might be to add a static setter:
      public static void setTimeout(int timeout)

        Attachments

          Activity

            People

            • Assignee:
              dmsmith DM Smith
              Reporter:
              mjdenham Martin Denham
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: