Uploaded image for project: 'PocketSword'
  1. PocketSword
  2. PS-11

Small adjustment to when the "active vers" is shown in the top navigation

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.1.0b1
    • Fix Version/s: None
    • Component/s: Module Display
    • Labels:
      None

      Description

      It seems that when you scroll down, the verse that is topmost visible is the verse that is shown to be "active" in the top navigation button.
      the number changes when the top part of a verse comes to the top-edge of the viewport.
      And continues showing that versenumber until the next-one comes to the top edge.

      it might be a good idea to adjust this slightly, because fon instance in picture IMG_0837.PNG you see that only half of the active verse is visible. Could it be good to have the "topmost fully visible verse" to be the active one?

      Also, I wanted to bookmark the last verse in a chapter, i cannot because i can't scroll it fully up to become the active one.
      (IMG_0840.PNG)

        Attachments

          Activity

          Hide
          niccarter Nic Carter added a comment -

          There's actually 2 issues here, the first being for what verse number is displayed in the ref title. After going back and forth between trying what you suggested and trying what is currently implemented, I decided that the current method works better for now. Have a look at the commentary tab. Especially when you have MHCC or (even more so) MHC open. What verse number should be displayed in the title when you're half-way through viewing the text for v1-5? Should it continue to say v1 or should it be saying v6? I chose to make it continue to say v1 rather than to jump to a verse that you're not looking at.
          However, this could change in the future if I change how I display text...

          The second issue you have here is for bookmarks & the method we use to bookmark a verse/passage. Please open a separate ticket for that.

          Show
          niccarter Nic Carter added a comment - There's actually 2 issues here, the first being for what verse number is displayed in the ref title. After going back and forth between trying what you suggested and trying what is currently implemented, I decided that the current method works better for now. Have a look at the commentary tab. Especially when you have MHCC or (even more so) MHC open. What verse number should be displayed in the title when you're half-way through viewing the text for v1-5? Should it continue to say v1 or should it be saying v6? I chose to make it continue to say v1 rather than to jump to a verse that you're not looking at. However, this could change in the future if I change how I display text... The second issue you have here is for bookmarks & the method we use to bookmark a verse/passage. Please open a separate ticket for that.
          Hide
          niccarter Nic Carter added a comment -

          Ahh, just saw PS-16 for bookmarks . . . thanks for adding it as another ticket

          Show
          niccarter Nic Carter added a comment - Ahh, just saw PS-16 for bookmarks . . . thanks for adding it as another ticket

            People

            • Assignee:
              niccarter Nic Carter
              Reporter:
              melonkernel Christoffer Björkskog
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: