Uploaded image for project: 'JSword'
  1. JSword
  2. JS-251 Fix all Language problems
  3. JS-192

Typo preventing localisation of languages in iso639.properties

    Details

    • Type: Sub-task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.1
    • Fix Version/s: 1.7
    • Component/s: o.c.common.util
    • Labels:
      None
    • Environment:

      All

      Description

      The following code in Languages.java seems to have a typo. The second assignment should be to allLangs:

      private static/* final */ResourceBundle commonLangs;
      private static/* final */ResourceBundle allLangs;
      static {
      try

      { commonLangs = ResourceBundle.getBundle("iso639", Locale.getDefault(), CWClassLoader.instance()); }

      catch (MissingResourceException e)

      { assert false; }
      try { commonLangs = ResourceBundle.getBundle("iso639full", Locale.getDefault(), CWClassLoader.instance()); } catch (MissingResourceException e) { assert false; }

      }

      I will make this simple fix and check it in.

        Attachments

          Activity

          mjdenham Martin Denham created issue -
          Hide
          mjdenham Martin Denham added a comment -

          I changed commonLangs to allLangs at the bottom of Languages.java

          Show
          mjdenham Martin Denham added a comment - I changed commonLangs to allLangs at the bottom of Languages.java
          mjdenham Martin Denham made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 1.6.1 [ 10138 ]
          Resolution Fixed [ 1 ]
          Hide
          mjdenham Martin Denham added a comment -

          This fix causes the error in JS-189 (SnowballAnalyzer configured for unavailable stemmer Spanish (Español)) to occur.

          SnowballAnalyzer relies on this bug to work correctly because it expects the language names that are in iso639full.properties.

          There are a lot of inter-related bugs I have been raising recently!

          Show
          mjdenham Martin Denham added a comment - This fix causes the error in JS-189 (SnowballAnalyzer configured for unavailable stemmer Spanish (Español)) to occur. SnowballAnalyzer relies on this bug to work correctly because it expects the language names that are in iso639full.properties. There are a lot of inter-related bugs I have been raising recently!
          mjdenham Martin Denham made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Assignee Martin Denham [ mjdenham ] DM Smith [ dmsmith ]
          Hide
          mjdenham Martin Denham added a comment -

          ...I also meant to say that I have reverted the fix.

          Show
          mjdenham Martin Denham added a comment - ...I also meant to say that I have reverted the fix.
          dmsmith DM Smith made changes -
          Parent JS-251 [ 25985 ]
          Issue Type Bug [ 1 ] Sub-task [ 5 ]
          Rank (Obsolete) 2110000000
          Hide
          dmsmith DM Smith added a comment -

          Used a singleton helper class to manage when the resource was loaded.

          Show
          dmsmith DM Smith added a comment - Used a singleton helper class to manage when the resource was loaded.
          dmsmith DM Smith made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Fix Version/s 1.7 [ 10139 ]
          Fix Version/s 1.6.1 [ 10138 ]
          Resolution Fixed [ 1 ]
          dmsmith DM Smith made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              dmsmith DM Smith
              Reporter:
              mjdenham Martin Denham
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: