Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.6.1
-
Component/s: o.c.jsword.book.install
-
Labels:None
-
Environment:
Android
Description
Maybe I am doing something wrong but I was having a lot of temporary swd files left on my Android sdcard so I think the temp file should be deleted in a finally block in AbstractSwordInstaller.run()
+ URI temp = null;
try
finally {
job.done();
+ // tidy up after ourselves
+ if (temp != null) {
+ try
catch (Exception e)
{ + log.warn("Error deleting temp download file:"+e.getMessage()); + }+ }
}
Attachments
Activity
Ah, I have just found the createTempFile and deleteOnExit in NetUtil and I see that if the JVM exits normally these files should be deleted but it would be nice to delete them explicitly after the download has completed in the same way that IndexDownloader.downloadIndex does an explicit deletion immediately after it has finished with a temporary file.
Yes. These should be deleted. JSword uses a Java mechanism that marks created temporary files for delete upon exit. Maybe that doesn't work in an Android environment.