Uploaded image for project: 'JSword'
  1. JSword
  2. JS-110

Module Version number validation is too strict

    Details

      Description

      Some modules like ESV no longer have a simple version number that can be represented as a float so the version number validation fails. I think that version number could in theory contain anything and so it may be better to remove the validation as in the following patch. The reason this affects me is because the plan is to include the module version number in the index download file name, as do PocketSword index downloads:

      Index: ConfigEntryType.java
      ===================================================================
      — ConfigEntryType.java (revision 1999)
      +++ ConfigEntryType.java (working copy)
      @@ -620,13 +620,7 @@
      public static final ConfigEntryType VERSION = new ConfigEntryType("Version", "1.0") {

      public boolean isAllowed(String aValue) {

      • try { - Float.parseFloat(aValue); - return true; - }

        catch (NumberFormatException e)

        { - return false; - }

        -
        + return true;
        }

      /**

        Attachments

          Activity

            People

            • Assignee:
              dmsmith DM Smith
              Reporter:
              mjdenham Martin Denham
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: