Uploaded image for project: 'Bible Desktop'
  1. Bible Desktop
  2. BD-120

Show Headings does not always show headings

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.6
    • Fix Version/s: 1.7
    • Component/s: book display
    • Labels:
      None
    • Environment:

      WinXP
      Actual version is 1.0.8

      Description

      View > Show Headings does not always show headings. For example, display:

      Genesis 1:29 – shows no headings
      Genesis 1:29-2:1 – shows two headings, one for each chapter.

      If Show Headings is on then the headings really should be shown.

        Attachments

          Activity

          Hide
          keith_watson Keith Watson added a comment -

          The menu item View > Show Headings controls whether or not headings/titles are displayed. Yet in the file jsword/book/basic/AbstractPassageBook.java, the getOsisIterator() function is hardcoded to turn titles off if the text does not span a chapter boundary. The function should instead be hardcoded to always include titles, and let the GUI turn them on or off.

          Show
          keith_watson Keith Watson added a comment - The menu item View > Show Headings controls whether or not headings/titles are displayed. Yet in the file jsword/book/basic/AbstractPassageBook.java, the getOsisIterator() function is hardcoded to turn titles off if the text does not span a chapter boundary. The function should instead be hardcoded to always include titles, and let the GUI turn them on or off.
          Hide
          dmsmith DM Smith added a comment -

          Good catch.

          The cause of this is that the titles are noisy in parallel view.

          I've made a change where they show when not in parallel view, but not in parallel view.

          I've also added type='x-gen" to indicate that the content is not part of the OSIS module but generated by JSword.

          Let me know what you think.

          Show
          dmsmith DM Smith added a comment - Good catch. The cause of this is that the titles are noisy in parallel view. I've made a change where they show when not in parallel view, but not in parallel view. I've also added type='x-gen" to indicate that the content is not part of the OSIS module but generated by JSword. Let me know what you think.
          Hide
          keith_watson Keith Watson added a comment -

          Adding the OSIS type was a good idea. I updated only the file which gives turning on the titles so I could see what the parallel view looks like. I don't think chapter titles add extra clutter. I like having them. If the text contains section titles those add more clutter than chapter titles do. I still think, if the user does not want titles, that is what the Show Headings menu item is for. The user can turn them on or off to their liking.

          Thanks.

          Show
          keith_watson Keith Watson added a comment - Adding the OSIS type was a good idea. I updated only the file which gives turning on the titles so I could see what the parallel view looks like. I don't think chapter titles add extra clutter. I like having them. If the text contains section titles those add more clutter than chapter titles do. I still think, if the user does not want titles, that is what the Show Headings menu item is for. The user can turn them on or off to their liking. Thanks.
          Hide
          dowens Daniel Owens added a comment -

          Not sure if this is the right place to report this, but a module I am developing has this problem. Some headings appear as headings, but some don't. They appear as canonical text (within the verse). This is also true of cross-references and footnotes. I can provide the OSIS file and compiled module if that's useful.

          Show
          dowens Daniel Owens added a comment - Not sure if this is the right place to report this, but a module I am developing has this problem. Some headings appear as headings, but some don't. They appear as canonical text (within the verse). This is also true of cross-references and footnotes. I can provide the OSIS file and compiled module if that's useful.
          Hide
          dowens Daniel Owens added a comment -

          Look at Genesis 1:26. You'll see a title text (I know it's in Vietnamese, but I will provide a similar shot in GnomeSword to highlight the heading) at the start of the verse and a cross-reference text at the end of the verse.

          Show
          dowens Daniel Owens added a comment - Look at Genesis 1:26. You'll see a title text (I know it's in Vietnamese, but I will provide a similar shot in GnomeSword to highlight the heading) at the start of the verse and a cross-reference text at the end of the verse.
          Hide
          dowens Daniel Owens added a comment -

          Same shot in GnomeSword.

          Show
          dowens Daniel Owens added a comment - Same shot in GnomeSword.
          Hide
          dowens Daniel Owens added a comment -

          One more clarification. This is for BD 1.6, the stable version, in Linux. The problem also appears in Windows XP.

          Show
          dowens Daniel Owens added a comment - One more clarification. This is for BD 1.6, the stable version, in Linux. The problem also appears in Windows XP.
          Hide
          dmsmith DM Smith added a comment -

          Daniel,
          The quote problem you are seeing is that JSword does not display verse 0 or chapter 0 and the module is hiding titles in these locations.
          This is a separate issue and is a JSword problem.

          Show
          dmsmith DM Smith added a comment - Daniel, The quote problem you are seeing is that JSword does not display verse 0 or chapter 0 and the module is hiding titles in these locations. This is a separate issue and is a JSword problem.

            People

            • Assignee:
              dmsmith DM Smith
              Reporter:
              keith_watson Keith Watson
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated: